fix: prevent property change event while batch update or onLoaded

farfromrefug · farfromrefug · commit 05ac9ea21a79 · 2024-02-07T17:46:12.000+01:00
diff --git a/packages/core/ui/core/properties/index.ts b/packages/core/ui/core/properties/index.ts
@@ -273,7 +273,7 @@ function getPropertySetter<T extends ViewBase, U>(property: Property<T, U>) {
 				}
 			}
 
-			if (this.hasListeners(eventName)) {
+			if (!this._suspendNativeUpdatesCount && this.hasListeners(eventName)) {
 				this.notify<PropertyChangeData>({
 					object: this,
 					eventName,
@@ -567,7 +567,7 @@ function setCssFunc<T extends Style, U>(property: CssProperty<T, U>, valueSource
 				}
 			}
 
-			if (this.hasListeners(eventName)) {
+			if (!view._suspendNativeUpdatesCount && this.hasListeners(eventName)) {
 				this.notify<PropertyChangeData>({
 					object: this,
 					eventName,
@@ -821,7 +821,7 @@ export class CssAnimationProperty<T extends Style, U> implements CssAnimationPro
 						}
 					}
 					const eventName = property.eventName;
-					if (computedValueChanged && this.hasListeners(eventName)) {
+					if (computedValueChanged && !view._suspendNativeUpdatesCount && this.hasListeners(eventName)) {
 						this.notify<PropertyChangeData>({
 							object: this,
 							eventName,
@@ -981,7 +981,7 @@ function setCssInheritedFunc<T extends Style, U>(property: InheritedCssProperty<
 				}
 			}
 
-			if (this.hasListeners(eventName)) {
+			if (!view._suspendNativeUpdatesCount && this.hasListeners(eventName)) {
 				this.notify<PropertyChangeData>({
 					object: this,
 					eventName,

Original file line number	Diff line number	Diff line change
`@@ -273,7 +273,7 @@ function getPropertySetter<T extends ViewBase, U>(property: Property<T, U>) {`
`273`	`273`	`}`
`274`	`274`	`}`
`275`	`275`
`276`		`- if (this.hasListeners(eventName)) {`
	`276`	`+ if (!this._suspendNativeUpdatesCount && this.hasListeners(eventName)) {`
`277`	`277`	`this.notify<PropertyChangeData>({`
`278`	`278`	`object: this,`
`279`	`279`	`eventName,`
`@@ -567,7 +567,7 @@ function setCssFunc<T extends Style, U>(property: CssProperty<T, U>, valueSource`
`567`	`567`	`}`
`568`	`568`	`}`
`569`	`569`
`570`		`- if (this.hasListeners(eventName)) {`
	`570`	`+ if (!view._suspendNativeUpdatesCount && this.hasListeners(eventName)) {`
`571`	`571`	`this.notify<PropertyChangeData>({`
`572`	`572`	`object: this,`
`573`	`573`	`eventName,`
`@@ -821,7 +821,7 @@ export class CssAnimationProperty<T extends Style, U> implements CssAnimationPro`
`821`	`821`	`}`
`822`	`822`	`}`
`823`	`823`	`const eventName = property.eventName;`
`824`		`- if (computedValueChanged && this.hasListeners(eventName)) {`
	`824`	`+ if (computedValueChanged && !view._suspendNativeUpdatesCount && this.hasListeners(eventName)) {`
`825`	`825`	`this.notify<PropertyChangeData>({`
`826`	`826`	`object: this,`
`827`	`827`	`eventName,`
`@@ -981,7 +981,7 @@ function setCssInheritedFunc<T extends Style, U>(property: InheritedCssProperty<`
`981`	`981`	`}`
`982`	`982`	`}`
`983`	`983`
`984`		`- if (this.hasListeners(eventName)) {`
	`984`	`+ if (!view._suspendNativeUpdatesCount && this.hasListeners(eventName)) {`
`985`	`985`	`this.notify<PropertyChangeData>({`
`986`	`986`	`object: this,`
`987`	`987`	`eventName,`