Detect "Label" issue list as issue list (refined-github#1232)

fregante · web-flow · commit bc11082b719e · 2018-03-30T14:16:02.000+07:00
diff --git a/source/content.js b/source/content.js
@@ -244,11 +244,11 @@ function ajaxedPagesHandler() {
 		enableFeature(addJumpToBottomLink);
 	}
 
-	if (pageDetect.isPRList() || pageDetect.isIssueList()) {
+	if (pageDetect.isIssueList()) {
 		enableFeature(addFilterCommentsByYou);
 	}
 
-	if (pageDetect.isPRList() || pageDetect.isIssueList() || pageDetect.isPR() || pageDetect.isIssue()) {
+	if (pageDetect.isIssueList() || pageDetect.isPR() || pageDetect.isIssue()) {
 		enableFeature(showRecentlyPushedBranches);
 	}
 
diff --git a/source/features/open-all-selected.js b/source/features/open-all-selected.js
@@ -1,7 +1,7 @@
 /* eslint-disable no-alert */
 import {h} from 'dom-chef';
 import select from 'select-dom';
-import {isIssueList, isPRList} from '../libs/page-detect';
+import {isIssueList} from '../libs/page-detect';
 
 const confirmationRequiredCount = 10;
 
@@ -25,7 +25,7 @@ function openSelected() {
 }
 
 export default function () {
-	if (!isIssueList() && !isPRList()) {
+	if (!isIssueList()) {
 		return;
 	}
 
diff --git a/source/libs/page-detect.js b/source/libs/page-detect.js
@@ -56,7 +56,7 @@ export const isGist = () => location.hostname.startsWith('gist.') || location.pa
 
 export const isIssue = () => /^issues\/\d+/.test(getRepoPath());
 
-export const isIssueList = () => getRepoPath() === 'issues';
+export const isIssueList = () => /^(issues$|pulls$|labels\/)/.test(getRepoPath());
 
 export const isIssueSearch = () => location.pathname.startsWith('/issues');
 
@@ -82,8 +82,6 @@ export const isPRCommit = () => /^pull\/\d+\/commits\/[0-9a-f]{5,40}/.test(getRe
 
 export const isPRFiles = () => /^pull\/\d+\/files/.test(getRepoPath());
 
-export const isPRList = () => getRepoPath() === 'pulls';
-
 export const isPRSearch = () => location.pathname.startsWith('/pulls');
 
 export const isQuickPR = () => isCompare() && /[?&]quick_pull=1(&|$)/.test(location.search);
diff --git a/test/page-detect.js b/test/page-detect.js
@@ -202,11 +202,17 @@ test('isIssue', urlMatcherMacro, pageDetect.isIssue, [
 ]);
 
 test('isIssueList', urlMatcherMacro, pageDetect.isIssueList, [
-	'http://github.com/sindresorhus/ava/issues'
+	'http://github.com/sindresorhus/ava/issues',
+	'https://github.com/sindresorhus/refined-github/pulls',
+	'https://github.com/sindresorhus/refined-github/labels/Priority%3A%20critical',
+	'https://github.com/sindresorhus/refined-github/issues?q=is%3Aclosed+sort%3Aupdated-desc'
 ], [
 	'http://github.com/sindresorhus/ava',
 	'https://github.com',
-	'https://github.com/sindresorhus/refined-github/issues/170'
+	'https://github.com/sindresorhus/refined-github/issues/170',
+	'https://github.com/sindresorhus/refined-github/pull/148',
+	'http://github.com/sindresorhus/issues',
+	'https://github.com/wildlifela/carmichael-lynch-2018/labels'
 ]);
 
 test('isIssueSearch', urlMatcherMacro, pageDetect.isIssueSearch, [
@@ -289,14 +295,6 @@ test('isPRFiles', urlMatcherMacro, pageDetect.isPRFiles, [
 	'https://github.com/sindresorhus/refined-github/pulls'
 ]);
 
-test('isPRList', urlMatcherMacro, pageDetect.isPRList, [
-	'https://github.com/sindresorhus/refined-github/pulls'
-], [
-	'http://github.com/sindresorhus/ava',
-	'https://github.com',
-	'https://github.com/sindresorhus/refined-github/pull/148'
-]);
-
 test('isPRSearch', urlMatcherMacro, pageDetect.isPRSearch, [
 	'https://github.com/pulls'
 ], [

Original file line number	Diff line number	Diff line change
`@@ -244,11 +244,11 @@ function ajaxedPagesHandler() {`
`244`	`244`	`enableFeature(addJumpToBottomLink);`
`245`	`245`	`}`
`246`	`246`
`247`		`- if (pageDetect.isPRList() \|\| pageDetect.isIssueList()) {`
	`247`	`+ if (pageDetect.isIssueList()) {`
`248`	`248`	`enableFeature(addFilterCommentsByYou);`
`249`	`249`	`}`
`250`	`250`
`251`		`- if (pageDetect.isPRList() \|\| pageDetect.isIssueList() \|\| pageDetect.isPR() \|\| pageDetect.isIssue()) {`
	`251`	`+ if (pageDetect.isIssueList() \|\| pageDetect.isPR() \|\| pageDetect.isIssue()) {`
`252`	`252`	`enableFeature(showRecentlyPushedBranches);`
`253`	`253`	`}`
`254`	`254`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/* eslint-disable no-alert */`
`2`	`2`	`import {h} from 'dom-chef';`
`3`	`3`	`import select from 'select-dom';`
`4`		`-import {isIssueList, isPRList} from '../libs/page-detect';`
	`4`	`+import {isIssueList} from '../libs/page-detect';`
`5`	`5`
`6`	`6`	`const confirmationRequiredCount = 10;`
`7`	`7`
`@@ -25,7 +25,7 @@ function openSelected() {`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`export default function () {`
`28`		`- if (!isIssueList() && !isPRList()) {`
	`28`	`+ if (!isIssueList()) {`
`29`	`29`	`return;`
`30`	`30`	`}`
`31`	`31`