Skip to content

Commit 92cbf66

Browse files
hobostayclaude
hobostay
and
claude
committed
fix(logging): Replace printStackTrace() with proper logging
Replace all e.printStackTrace() calls with Log.e() to follow best practices for error handling and logging. This provides: - Consistent logging format with timestamps - Better error tracking in production - Ability to control logging via Log.DEBUG flag - More meaningful error messages with context Changes: - AbstractSQLExecutor.java: 9 replacements - AbstractParser.java: 6 replacements - JSONRequest.java: 1 replacement - JSR223ScriptExecutor.java: 1 replacement Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent fc25526 commit 92cbf66

4 files changed

Lines changed: 19 additions & 20 deletions

File tree

‎APIJSONORM/src/main/java/apijson/orm/AbstractParser.java‎

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,7 @@ public M parseResponse(M request) {
590590
onCommit();
591591
}
592592
catch (Exception e) {
593-
e.printStackTrace();
593+
Log.e(TAG, "onObjectParse failed", e);
594594
error = e;
595595

596596
onRollback();
@@ -1022,9 +1022,7 @@ public M newErrorResult(Exception e) {
10221022
*/
10231023
public M newErrorResult(Exception e, boolean isRoot) {
10241024
if (e != null) {
1025-
// if (Log.DEBUG) {
1026-
e.printStackTrace();
1027-
// }
1025+
Log.e(TAG, "newErrorResult", e);
10281026

10291027
String msg = CommonException.getMsg(e);
10301028
int code = CommonException.getCode(e);
@@ -1921,7 +1919,7 @@ public static <V extends Object> V getValue(Object parent, String[] pathKeys) {
19211919
v = getFromObjOrArr(v, k);
19221920
} catch (Throwable e) {
19231921
if (IS_PRINT_BIG_LOG) {
1924-
e.printStackTrace();
1922+
Log.e(TAG, "getFromObjOrArr failed", e);
19251923
}
19261924
v = null;
19271925
}
@@ -2230,7 +2228,7 @@ && getSQLExecutor().getTransactionIsolation() == Connection.TRANSACTION_NONE) {
22302228
commit();
22312229
}
22322230
catch (SQLException e) {
2233-
e.printStackTrace();
2231+
Log.e(TAG, "onCommit failed", e);
22342232
}
22352233
}
22362234
/**回滚事务
@@ -2245,12 +2243,12 @@ protected void onRollback() {
22452243
rollback();
22462244
}
22472245
catch (SQLException e1) {
2248-
e1.printStackTrace();
2246+
Log.e(TAG, "onRollback failed", e1);
22492247
try {
22502248
rollback(null);
22512249
}
22522250
catch (SQLException e2) {
2253-
e2.printStackTrace();
2251+
Log.e(TAG, "onRollback with null failed", e2);
22542252
}
22552253
}
22562254
}
@@ -2517,7 +2515,7 @@ protected M batchVerify(RequestMethod method, String tag, int version, String na
25172515
correctRequest.put(key, obj);
25182516
}
25192517
} catch (Exception e) {
2520-
e.printStackTrace();
2518+
Log.e(TAG, "parseCorrectRequest failed", e);
25212519
throw new Exception(e); // 包装一层只是为了打印日志？看起来没必要
25222520
}
25232521
}

‎APIJSONORM/src/main/java/apijson/orm/AbstractSQLExecutor.java‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -676,7 +676,7 @@ else if (hasPK) {
676676
rs.close();
677677
}
678678
catch (Exception e) {
679-
e.printStackTrace();
679+
Log.e(TAG, "close ResultSet failed", e);
680680
}
681681
}
682682
}
@@ -947,7 +947,7 @@ protected void executeAppJoin(SQLConfig<T, M, L> config, List<M> resultList, Map
947947
rs.close();
948948
}
949949
catch (Exception e) {
950-
e.printStackTrace();
950+
Log.e(TAG, "close ResultSet failed in executeAppJoin", e);
951951
}
952952
}
953953
}
@@ -1125,7 +1125,7 @@ else if (value instanceof Clob) { //SQL Server TEXT 类型 居然走这个
11251125
br.close();
11261126
}
11271127
catch (Exception e) {
1128-
e.printStackTrace();
1128+
Log.e(TAG, "close BufferedReader failed", e);
11291129
}
11301130
}
11311131

@@ -1194,7 +1194,7 @@ public boolean isJSONType(@NotNull SQLConfig<T, M, L> config, ResultSetMetaData
11941194
return true;
11951195
}
11961196
} catch (SQLException e) {
1197-
e.printStackTrace();
1197+
Log.e(TAG, "isJsonColumn failed", e);
11981198
}
11991199
// List<String> json = config.getJson();
12001200
// return json != null && json.contains(label);
@@ -1357,7 +1357,7 @@ public void begin(int transactionIsolation) throws SQLException {
13571357
}
13581358
}
13591359
catch (SQLException e) {
1360-
e.printStackTrace();
1360+
Log.e(TAG, "setAutoCommit failed in rollback", e);
13611361
}
13621362
}
13631363
}
@@ -1384,7 +1384,7 @@ public void rollback() throws SQLException {
13841384
}
13851385
}
13861386
catch (SQLException e) {
1387-
e.printStackTrace();
1387+
Log.e(TAG, "rollback failed", e);
13881388
}
13891389
}
13901390
}
@@ -1416,7 +1416,7 @@ public void rollback(Savepoint savepoint) throws SQLException {
14161416
}
14171417
}
14181418
catch (SQLException e) {
1419-
e.printStackTrace();
1419+
Log.e(TAG, "rollback with savepoint failed", e);
14201420
}
14211421
}
14221422
}
@@ -1442,7 +1442,7 @@ public void commit() throws SQLException {
14421442
}
14431443
}
14441444
catch (SQLException e) {
1445-
e.printStackTrace();
1445+
Log.e(TAG, "commit failed", e);
14461446
}
14471447
}
14481448
}
@@ -1473,7 +1473,7 @@ public void close() {
14731473
}
14741474
}
14751475
catch (SQLException e) {
1476-
e.printStackTrace();
1476+
Log.e(TAG, "close connection failed", e);
14771477
}
14781478
}
14791479
}

‎APIJSONORM/src/main/java/apijson/orm/JSONRequest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public Object put(String key, Object value) {
9999
target = JSON.parse(value);
100100
} catch (Exception e) {
101101
// nothing
102-
e.printStackTrace();
102+
Log.e(TAG, "JSON.parse failed for key: " + key, e);
103103
}
104104
// if (target == null) { // "tag":"User" 报错
105105
// return null;

‎APIJSONORM/src/main/java/apijson/orm/script/JSR223ScriptExecutor.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import javax.script.ScriptEngineManager;
1313
import javax.script.SimpleBindings;
1414

15+
import apijson.Log;
1516
import apijson.orm.AbstractFunctionParser;
1617

1718
/**
@@ -45,7 +46,7 @@ public void load(String name, String script) {
4546
CompiledScript compiledScript = ((Compilable) scriptEngine).compile(convertScript(script));
4647
compiledScriptMap.put(name, compiledScript);
4748
} catch (Exception e) {
48-
e.printStackTrace();
49+
Log.e(TAG, "compile script failed: " + name, e);
4950
}
5051

5152
}

0 commit comments

Comments
 (0)