Revert deletion of _Mock object and fix ReadTheDocs.

HexDecimal · HexDecimal · commit b9c86330c0b3 · 2018-08-26T11:30:05.000-07:00
diff --git a/docs/conf.py b/docs/conf.py
@@ -370,3 +370,5 @@
     'https://docs.python.org/2/': None,
     'https://docs.scipy.org/doc/numpy/': None,
 }
+
+os.environ['READTHEDOCS'] = 'True'
diff --git a/tcod/libtcod.py b/tcod/libtcod.py
@@ -32,6 +32,32 @@ def BKGND_ALPHA(a):
 def BKGND_ADDALPHA(a):
     return BKGND_ADDA | (int(a * 255) << 8)
 
-if not _os.environ.get('READTHEDOCS'):
+class _Mock(object):
+    """Mock object needed for ReadTheDocs."""
+
+    CData = () # This gets passed to an isinstance call.
+
+    @staticmethod
+    def def_extern():
+        """Pass def_extern call silently."""
+        return lambda func: func
+
+    def __getattr__(self, attr):
+        """This object pretends to have everything."""
+        return self
+
+    def __call__(self, *args, **kargs):
+        """Suppress any other calls"""
+        return self
+
+    def __str__(self):
+        """Just have ? in case anything leaks as a parameter default."""
+        return '?'
+
+
+if _os.environ.get('READTHEDOCS'):
+    # Mock the lib and ffi objects needed to compile docs for readthedocs.io
     # Allows an import without building the cffi module first.
+    lib = ffi = _Mock()
+else:
     from tcod._libtcod import lib, ffi
diff --git a/tcod/map.py b/tcod/map.py
@@ -37,6 +37,7 @@
 
 from tcod.libtcod import lib, ffi
 import tcod._internal
+import tcod.constants
 
 
 class Map(object):
@@ -98,7 +99,8 @@ def fov(self):
         return buffer.T if self._order == 'F' else buffer
 
     def compute_fov(self, x, y, radius=0, light_walls=True,
-                    algorithm=lib.FOV_RESTRICTIVE):
+                    algorithm=tcod.constants.FOV_RESTRICTIVE):
+        # type (int, int, int, bool, int) -> None
         """Compute a field-of-view on the current instance.
 
         Args:

Original file line number	Diff line number	Diff line change
`@@ -370,3 +370,5 @@`
`370`	`370`	`'https://docs.python.org/2/': None,`
`371`	`371`	`'https://docs.scipy.org/doc/numpy/': None,`
`372`	`372`	`}`
	`373`	`+`
	`374`	`+os.environ['READTHEDOCS'] = 'True'`