Optimise owner check depending on your implementation and no longer create default users on IFC4. Can result in 50% faster script running on long scripted operations.

Moult · Moult · commit 109149a0be14 · 2021-10-29T18:04:17.000+11:00
diff --git a/src/blenderbim/blenderbim/bim/handler.py b/src/blenderbim/blenderbim/bim/handler.py
@@ -202,14 +202,15 @@ def ensureIfcExported(scene):
 
 
 def get_application(ifc):
+    # TODO: cache this for even faster application retrieval. It honestly makes a difference on long scripts.
     version = get_application_version()
     for element in ifc.by_type("IfcApplication"):
         if element.ApplicationIdentifier == "BlenderBIM" and element.Version == version:
             return element
     return ifcopenshell.api.run(
         "owner.add_application",
         ifc,
-        version=get_application_version(),
+        version=version,
         application_full_name="BlenderBIM Add-on",
         application_identifier="BlenderBIM",
     )
diff --git a/src/blenderbim/blenderbim/bim/import_ifc.py b/src/blenderbim/blenderbim/bim/import_ifc.py
@@ -1211,12 +1211,12 @@ def place_object_in_decomposition_collection(self, element, obj):
         elif element.is_a("IfcGridAxis"):
             return
         elif element.GlobalId in self.collections:
-            return self.collections[element.GlobalId].objects.link(obj)
-        elif getattr(element, "Decomposes", None):
-            aggregate = ifcopenshell.util.element.get_aggregate(element)
-            collection = self.collections[aggregate.GlobalId]
+            collection = self.collections[element.GlobalId]
             collection.name = obj.name
             return collection.objects.link(obj)
+        elif getattr(element, "Decomposes", None):
+            aggregate = ifcopenshell.util.element.get_aggregate(element)
+            return self.collections[aggregate.GlobalId].objects.link(obj)
         else:
             return self.place_object_in_spatial_decomposition_collection(element, obj)
 
diff --git a/src/blenderbim/blenderbim/bim/module/project/operator.py b/src/blenderbim/blenderbim/bim/module/project/operator.py
@@ -61,10 +61,11 @@ def _execute(self, context):
         )
         self.file = IfcStore.get_file()
 
-        person = blenderbim.core.owner.add_person(tool.Ifc)
-        organisation = blenderbim.core.owner.add_organisation(tool.Ifc)
-        user = blenderbim.core.owner.add_person_and_organisation(tool.Ifc, person=person, organisation=organisation)
-        blenderbim.core.owner.set_user(tool.Owner, user=user)
+        if self.file.schema == "IFC2X3":
+            person = blenderbim.core.owner.add_person(tool.Ifc)
+            organisation = blenderbim.core.owner.add_organisation(tool.Ifc)
+            user = blenderbim.core.owner.add_person_and_organisation(tool.Ifc, person=person, organisation=organisation)
+            blenderbim.core.owner.set_user(tool.Owner, user=user)
 
         project = bpy.data.objects.new(self.get_name("IfcProject", "My Project"), None)
         site = bpy.data.objects.new(self.get_name("IfcSite", "My Site"), None)
diff --git a/src/ifcopenshell-python/ifcopenshell/api/owner/create_owner_history.py b/src/ifcopenshell-python/ifcopenshell/api/owner/create_owner_history.py
@@ -12,10 +12,11 @@ def __init__(self, file, **settings):
 
     def execute(self):
         user = ifcopenshell.api.owner.settings.get_user(self.file)
+        if self.file.schema != "IFC2X3" and not user:
+            return
         application = ifcopenshell.api.owner.settings.get_application(self.file)
-        if self.file.schema != "IFC2X3":
-            if not user or not application:
-                return
+        if self.file.schema != "IFC2X3" and not application:
+            return
         return self.file.create_entity(
             "IfcOwnerHistory",
             **{
diff --git a/src/ifcopenshell-python/ifcopenshell/api/owner/update_owner_history.py b/src/ifcopenshell-python/ifcopenshell/api/owner/update_owner_history.py
@@ -15,8 +15,10 @@ def execute(self):
         if not hasattr(self.settings["element"], "OwnerHistory"):
             return
         user = ifcopenshell.api.owner.settings.get_user(self.file)
+        if not user:
+            return
         application = ifcopenshell.api.owner.settings.get_application(self.file)
-        if not user or not application:
+        if not application:
             return
         if not self.settings["element"].OwnerHistory:
             self.settings["element"].OwnerHistory = ifcopenshell.api.run(
