Fix ConcurrentModificationException when iterating through connections returned by getConnections()

hovis · hovis · commit fc30bf2f448e · 2019-07-30T11:37:55.000+01:00
diff --git a/src/main/java/org/java_websocket/server/WebSocketServer.java b/src/main/java/org/java_websocket/server/WebSocketServer.java
@@ -279,7 +279,9 @@ public void stop() throws IOException , InterruptedException {
 	 * @since 1.3.8
 	 */
 	public Collection<WebSocket> getConnections() {
-		return Collections.unmodifiableCollection( new ArrayList<WebSocket>(connections) );
+		synchronized (connections) {
+			return Collections.unmodifiableCollection( new ArrayList<WebSocket>(connections) );
+		}
 	}
 
 	public InetSocketAddress getAddress() {
