Skip to content

Commit 5eeb03d

Browse files
committed
websocketimpl: avoid string copy unless logging trace message
1 parent aad6654 commit 5eeb03d

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/main/java/org/java_websocket/WebSocketImpl.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -224,10 +224,11 @@ public WebSocketImpl(WebSocketListener listener, Draft draft) {
224224
*/
225225
public void decode(ByteBuffer socketBuffer) {
226226
assert (socketBuffer.hasRemaining());
227-
log.trace("process({}): ({})", socketBuffer.remaining(),
228-
(socketBuffer.remaining() > 1000 ? "too big to display"
229-
: new String(socketBuffer.array(), socketBuffer.position(), socketBuffer.remaining())));
230-
227+
if (log.isTraceEnabled()) {
228+
log.trace("process({}): ({})", socketBuffer.remaining(),
229+
(socketBuffer.remaining() > 1000 ? "too big to display"
230+
: new String(socketBuffer.array(), socketBuffer.position(), socketBuffer.remaining())));
231+
}
231232
if (readyState != ReadyState.NOT_YET_CONNECTED) {
232233
if (readyState == ReadyState.OPEN) {
233234
decodeFrames(socketBuffer);

0 commit comments

Comments
 (0)