Fixed filter dropdown's text not being updated correctly after switching between Folders and Files PickModes

yasirkula · yasirkula · commit 99fc7ba43d48 · 2022-07-26T12:47:13.000+03:00
diff --git a/Plugins/SimpleFileBrowser/Scripts/FileBrowser.cs b/Plugins/SimpleFileBrowser/Scripts/FileBrowser.cs
@@ -278,7 +278,10 @@ public static string AllFilesFilterText
 							m_instance.filters[0] = m_instance.allFilesFilter;
 
 						if( m_instance.filtersDropdown.options[0].text == oldValue )
+						{
 							m_instance.filtersDropdown.options[0].text = value;
+							m_instance.filtersDropdown.RefreshShownValue();
+						}
 					}
 				}
 			}
@@ -296,7 +299,10 @@ public static string FoldersFilterText
 					m_foldersFilterText = value;
 
 					if( m_instance && m_instance.filtersDropdown.options[0].text == oldValue )
+					{
 						m_instance.filtersDropdown.options[0].text = value;
+						m_instance.filtersDropdown.RefreshShownValue();
+					}
 				}
 			}
 		}
@@ -702,7 +708,6 @@ private set
 				{
 					filtersDropdown.options[0].text = FoldersFilterText;
 					filtersDropdown.value = 0;
-					filtersDropdown.RefreshShownValue();
 					filtersDropdown.interactable = false;
 				}
 				else
@@ -711,6 +716,8 @@ private set
 					filtersDropdown.interactable = true;
 				}
 
+				filtersDropdown.RefreshShownValue();
+
 				Text placeholder = filenameInputField.placeholder as Text;
 				if( placeholder )
 					placeholder.gameObject.SetActive( m_pickerMode != PickMode.Folders );

Original file line number	Diff line number	Diff line change
`@@ -278,7 +278,10 @@ public static string AllFilesFilterText`
`278`	`278`	`m_instance.filters[0] = m_instance.allFilesFilter;`
`279`	`279`
`280`	`280`	`if( m_instance.filtersDropdown.options[0].text == oldValue )`
	`281`	`+ {`
`281`	`282`	`m_instance.filtersDropdown.options[0].text = value;`
	`283`	`+ m_instance.filtersDropdown.RefreshShownValue();`
	`284`	`+ }`
`282`	`285`	`}`
`283`	`286`	`}`
`284`	`287`	`}`
`@@ -296,7 +299,10 @@ public static string FoldersFilterText`
`296`	`299`	`m_foldersFilterText = value;`
`297`	`300`
`298`	`301`	`if( m_instance && m_instance.filtersDropdown.options[0].text == oldValue )`
	`302`	`+ {`
`299`	`303`	`m_instance.filtersDropdown.options[0].text = value;`
	`304`	`+ m_instance.filtersDropdown.RefreshShownValue();`
	`305`	`+ }`
`300`	`306`	`}`
`301`	`307`	`}`
`302`	`308`	`}`
`@@ -702,7 +708,6 @@ private set`
`702`	`708`	`{`
`703`	`709`	`filtersDropdown.options[0].text = FoldersFilterText;`
`704`	`710`	`filtersDropdown.value = 0;`
`705`		`- filtersDropdown.RefreshShownValue();`
`706`	`711`	`filtersDropdown.interactable = false;`
`707`	`712`	`}`
`708`	`713`	`else`
`@@ -711,6 +716,8 @@ private set`
`711`	`716`	`filtersDropdown.interactable = true;`
`712`	`717`	`}`
`713`	`718`
	`719`	`+ filtersDropdown.RefreshShownValue();`
	`720`	`+`
`714`	`721`	`Text placeholder = filenameInputField.placeholder as Text;`
`715`	`722`	`if( placeholder )`
`716`	`723`	`placeholder.gameObject.SetActive( m_pickerMode != PickMode.Folders );`