changed api and fixed start/stop thread creation

Brendan Whitfield · Brendan Whitfield · commit b159e9bd0eaf · 2014-11-23T15:28:45.000-05:00
diff --git a/obd/async.py b/obd/async.py
@@ -11,33 +11,41 @@ class Async():
 
 	def __init__(self, portstr=None):
 		self.connection = obd.OBD(portstr)
-		self.running = True
 		self.commands = {} # key = OBDCommand, value = Response
-		
+		self.thread = None
+		self.start()
+
+	def start(self):
+		self.running = True
 		if self.connection.is_connected():
 			self.thread = threading.Thread(target=self.run, args=(self.connection,))
 			self.thread.start()
 
-	def close(self):
+	def stop(self):
 		self.running = False
-		self.thread.join()
-		self.connection.close
+		if self.thread is not None:
+			self.thread.join()
+			self.thread = None
 
-	def get(self, c):
-		if self.commands.has_key(c):
-			return self.commands[c]
-		else:
-			return Response()
+	def close(self):
+		self.stop()
+		self.connection.close()
 
-	def add(self, *commands):
+	def watch(self, *commands):
 		for c in commands:
 			if isinstance(c, OBDCommand) and self.connection.has_command(c):
 				if not self.commands.has_key(c):
 					self.commands[c] = Response() # give it an initial value
 
-	def remove(self, c):
+	def unwatch(self, c):
 		self.commands.pop(c, None)
 
+	def get(self, c):
+		if self.commands.has_key(c):
+			return self.commands[c]
+		else:
+			return Response()
+
 	def run(self, connection):
 		# loop until the stop signal is recieved
 		while self.running:
diff --git a/obd/port.py b/obd/port.py
@@ -140,7 +140,7 @@ def send(self, cmd):
 	def get(self):
 		"""Internal use only: not a public interface"""
 
-		attempts = 2
+		attempts = 1
 		result = ""
 
 		if self.port is not None:
