PDEX + PPS: add blocking callbacks

JakubValtar · JakubValtar · commit e597e87a7a2f · 2016-05-06T19:34:17.000+02:00
diff --git a/java/src/processing/mode/java/pdex/PDEX.java b/java/src/processing/mode/java/pdex/PDEX.java
@@ -102,21 +102,21 @@ public PDEX(JavaEditor editor, PreprocessingService pps) {
   public void handleShowUsage(int tabIndex, int startTabOffset, int stopTabOffset) {
     Messages.log("* handleShowUsage");
     if (!enabled) return; // show usage disabled if java tabs
-    pps.whenDone(ps -> showUsage.findUsageAndUpdateTree(ps, tabIndex, startTabOffset, stopTabOffset));
+    pps.whenDoneBlocking(ps -> showUsage.findUsageAndUpdateTree(ps, tabIndex, startTabOffset, stopTabOffset));
   }
 
 
   public void handleRename(int tabIndex, int startTabOffset, int stopTabOffset) {
     Messages.log("* handleRename");
     if (!enabled) return;  // refactoring disabled w/ java tabs
-    pps.whenDone(ps -> rename.handleRename(ps, tabIndex, startTabOffset, stopTabOffset));
+    pps.whenDoneBlocking(ps -> rename.handleRename(ps, tabIndex, startTabOffset, stopTabOffset));
   }
 
 
   public void handleCtrlClick(int tabIndex, int offset) {
     Messages.log("* handleCtrlClick");
     if (!enabled) return;  // disabled w/ java tabs
-    pps.whenDone(ps -> handleCtrlClick(ps, tabIndex, offset));
+    pps.whenDoneBlocking(ps -> handleCtrlClick(ps, tabIndex, offset));
   }
 
 
diff --git a/java/src/processing/mode/java/pdex/PreprocessingService.java b/java/src/processing/mode/java/pdex/PreprocessingService.java
@@ -38,6 +38,9 @@
 import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.CopyOnWriteArraySet;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.function.Consumer;
 import java.util.stream.Collectors;
@@ -125,7 +128,7 @@ private void mainLoop() {
 
         synchronized (requestLock) {
           if (requestQueue.isEmpty()) {
-            Messages.log("PPS: Completed");
+            Messages.log("PPS: Done");
             preprocessingTask.complete(prevResult);
           }
         }
@@ -176,17 +179,33 @@ public void notifyCodeFolderChanged() {
   }
 
 
-  public void whenDone(Consumer<PreprocessedSketch> callback) {
-    if (!isEnabled) return;
+  private CompletableFuture<?> registerCallback(Consumer<PreprocessedSketch> callback) {
     synchronized (requestLock) {
       lastCallback = preprocessingTask
           // Run callback after both preprocessing task and previous callback
           .thenAcceptBothAsync(lastCallback, (ps, a) -> callback.accept(ps))
           // Make sure exception in callback won't cancel whole callback chain
           .handleAsync((res, e) -> {
-            if (e != null) Messages.loge("exception in preprocessing callback", e);
+            if (e != null) Messages.loge("PPS: exception in callback", e);
             return res;
           });
+      return lastCallback;
+    }
+  }
+
+
+  public void whenDone(Consumer<PreprocessedSketch> callback) {
+    if (!isEnabled) return;
+    registerCallback(callback);
+  }
+
+
+  public void whenDoneBlocking(Consumer<PreprocessedSketch> callback) {
+    if (!isEnabled) return;
+    try {
+      registerCallback(callback).get(3000, TimeUnit.SECONDS);
+    } catch (InterruptedException | ExecutionException | TimeoutException e) {
+      // Don't care
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -102,21 +102,21 @@ public PDEX(JavaEditor editor, PreprocessingService pps) {`
`102`	`102`	`public void handleShowUsage(int tabIndex, int startTabOffset, int stopTabOffset) {`
`103`	`103`	`Messages.log("* handleShowUsage");`
`104`	`104`	`if (!enabled) return; // show usage disabled if java tabs`
`105`		`- pps.whenDone(ps -> showUsage.findUsageAndUpdateTree(ps, tabIndex, startTabOffset, stopTabOffset));`
	`105`	`+ pps.whenDoneBlocking(ps -> showUsage.findUsageAndUpdateTree(ps, tabIndex, startTabOffset, stopTabOffset));`
`106`	`106`	`}`
`107`	`107`
`108`	`108`
`109`	`109`	`public void handleRename(int tabIndex, int startTabOffset, int stopTabOffset) {`
`110`	`110`	`Messages.log("* handleRename");`
`111`	`111`	`if (!enabled) return; // refactoring disabled w/ java tabs`
`112`		`- pps.whenDone(ps -> rename.handleRename(ps, tabIndex, startTabOffset, stopTabOffset));`
	`112`	`+ pps.whenDoneBlocking(ps -> rename.handleRename(ps, tabIndex, startTabOffset, stopTabOffset));`
`113`	`113`	`}`
`114`	`114`
`115`	`115`
`116`	`116`	`public void handleCtrlClick(int tabIndex, int offset) {`
`117`	`117`	`Messages.log("* handleCtrlClick");`
`118`	`118`	`if (!enabled) return; // disabled w/ java tabs`
`119`		`- pps.whenDone(ps -> handleCtrlClick(ps, tabIndex, offset));`
	`119`	`+ pps.whenDoneBlocking(ps -> handleCtrlClick(ps, tabIndex, offset));`
`120`	`120`	`}`
`121`	`121`
`122`	`122`