PDEX + PPS: remove unnecessary problem list

JakubValtar · JakubValtar · commit 5626331c851c · 2016-05-07T01:24:48.000+02:00
diff --git a/java/src/processing/mode/java/pdex/PDEX.java b/java/src/processing/mode/java/pdex/PDEX.java
@@ -876,7 +876,8 @@ public void dispose() {
 
     private void handleSketchProblems(PreprocessedSketch ps) {
       // Process problems
-      final List<Problem> problems = ps.problems.stream()
+      IProblem[] iproblems = ps.compilationUnit.getProblems();
+      final List<Problem> problems = Arrays.stream(iproblems)
           // Filter Warnings if they are not enabled
           .filter(iproblem -> !(iproblem.isWarning() && !JavaMode.warningsEnabled))
           // Hide a useless error which is produced when a line ends with
diff --git a/java/src/processing/mode/java/pdex/PreprocessedSketch.java b/java/src/processing/mode/java/pdex/PreprocessedSketch.java
@@ -2,7 +2,6 @@
 
 import com.google.classpath.ClassPath;
 
-import org.eclipse.jdt.core.compiler.IProblem;
 import org.eclipse.jdt.core.dom.ASTNode;
 import org.eclipse.jdt.core.dom.CompilationUnit;
 
@@ -38,8 +37,6 @@ public class PreprocessedSketch {
   public final boolean hasSyntaxErrors;
   public final boolean hasCompilationErrors;
 
-  public final List<IProblem> problems;
-
   public final List<ImportStatement> programImports;
   public final List<ImportStatement> coreAndDefaultImports;
   public final List<ImportStatement> codeFolderImports;
@@ -218,8 +215,6 @@ public static class Builder {
     public boolean hasSyntaxErrors;
     public boolean hasCompilationErrors;
 
-    public List<IProblem> problems = new ArrayList<>();
-
     public final List<ImportStatement> programImports = new ArrayList<>();
     public final List<ImportStatement> coreAndDefaultImports = new ArrayList<>();
     public final List<ImportStatement> codeFolderImports = new ArrayList<>();
@@ -254,8 +249,6 @@ private PreprocessedSketch(Builder b) {
     hasSyntaxErrors = b.hasSyntaxErrors;
     hasCompilationErrors = b.hasCompilationErrors;
 
-    problems = Collections.unmodifiableList(b.problems);
-
     programImports = Collections.unmodifiableList(b.programImports);
     coreAndDefaultImports = Collections.unmodifiableList(b.coreAndDefaultImports);
     codeFolderImports = Collections.unmodifiableList(b.codeFolderImports);
diff --git a/java/src/processing/mode/java/pdex/PreprocessingService.java b/java/src/processing/mode/java/pdex/PreprocessingService.java
@@ -412,7 +412,6 @@ private PreprocessedSketch preprocessSketch(PreprocessedSketch prevResult) {
 
     // Get compilation problems
     List<IProblem> bindingsProblems = Arrays.asList(bindingsCU.getProblems());
-    result.problems.addAll(bindingsProblems);
     result.hasCompilationErrors = bindingsProblems.stream()
         .anyMatch(IProblem::isError);
 
