PDEX + PPS: make rename and undo work together

JakubValtar · JakubValtar · commit 5222f0717214 · 2016-05-06T19:38:54.000+02:00
diff --git a/app/src/processing/app/ui/Editor.java b/app/src/processing/app/ui/Editor.java
@@ -2669,7 +2669,11 @@ public void prepareRun() {
 
     // make sure any edits have been stored
     //current.setProgram(editor.getText());
-    sketch.getCurrentCode().setProgram(getText());
+    for (SketchCode sc : sketch.getCode()) {
+      try {
+        sc.setProgram(sc.getDocumentText());
+      } catch (BadLocationException e) { }
+    }
 
 //    // if an external editor is being used, need to grab the
 //    // latest version of the code from the file.
diff --git a/java/src/processing/mode/java/pdex/PDEX.java b/java/src/processing/mode/java/pdex/PDEX.java
@@ -51,14 +51,16 @@
 import javax.swing.JScrollPane;
 import javax.swing.JTextField;
 import javax.swing.JTree;
+import javax.swing.text.BadLocationException;
 import javax.swing.tree.DefaultMutableTreeNode;
 import javax.swing.tree.DefaultTreeCellRenderer;
 import javax.swing.tree.DefaultTreeModel;
 import javax.swing.tree.TreeModel;
 
 import processing.app.Messages;
-import processing.app.Preferences;
 import processing.app.Sketch;
+import processing.app.SketchCode;
+import processing.app.syntax.SyntaxDocument;
 import processing.app.ui.EditorStatus;
 import processing.app.ui.Toolkit;
 import processing.mode.java.JavaEditor;
@@ -657,24 +659,33 @@ void rename(PreprocessedSketch ps, IBinding binding, String newName) {
       final int currentOffset = editor.getCaretOffset();
       mappedNodes.entrySet().forEach(entry -> {
         int tabIndex = entry.getKey();
-        sketch.setCurrentCode(tabIndex);
+        SketchCode sketchCode = sketch.getCode(tabIndex);
+
+        SyntaxDocument document = (SyntaxDocument) sketchCode.getDocument();
 
         List<SketchInterval> nodes = entry.getValue();
         nodes.stream()
             // Replace from the end so all unprocess offsets stay valid
             .sorted(Comparator.comparing((SketchInterval si) -> si.startTabOffset).reversed())
             .forEach(si -> {
               // Make sure offsets are in bounds
-              int length = editor.getTextArea().getDocumentLength();
-              if (si.startTabOffset >= 0 && si.startTabOffset <= length &&
-                  si.stopTabOffset >= 0 && si.stopTabOffset <= length) {
+              int documentLength = document.getLength();
+              if (si.startTabOffset >= 0 && si.startTabOffset <= documentLength &&
+                  si.stopTabOffset >= 0 && si.stopTabOffset <= documentLength) {
                 // Replace the code
-                editor.getTextArea().select(si.startTabOffset, si.stopTabOffset);
-                editor.getTextArea().setSelectedText(newName);
+                int length = si.stopTabOffset - si.startTabOffset;
+                try {
+                  document.remove(si.startTabOffset, length);
+                  document.insertString(si.startTabOffset, newName, null);
+                } catch (BadLocationException e) { /* Whatever */ }
               }
             });
 
-        sketch.setModified(true);
+        try {
+          sketchCode.setProgram(document.getText(0, document.getLength()));
+        } catch (BadLocationException e) { /* Whatever */ }
+        sketchCode.setModified(true);
+        editor.repaintHeader();
       });
 
       int precedingIntervals =
diff --git a/java/src/processing/mode/java/pdex/PreprocessingService.java b/java/src/processing/mode/java/pdex/PreprocessingService.java
@@ -261,14 +261,10 @@ private PreprocessedSketch preprocessSketch(PreprocessedSketch prevResult) {
     for (SketchCode sc : sketch.getCode()) {
       if (sc.isExtension("pde")) {
         tabStartsList.append(workBuffer.length());
-        if (sketch.getCurrentCode().equals(sc)) {
-          try {
-            workBuffer.append(sc.getDocumentText());
-          } catch (BadLocationException e) {
-            e.printStackTrace();
-          }
-        } else {
-          workBuffer.append(sc.getProgram());
+        try {
+          workBuffer.append(sc.getDocumentText());
+        } catch (BadLocationException e) {
+          e.printStackTrace();
         }
         workBuffer.append('\n');
       }
