throw exception if Server constructor fails

benfry · benfry · commit 291be6065f87 · 2014-07-30T21:37:12.000-04:00
diff --git a/core/todo.txt b/core/todo.txt
@@ -30,14 +30,26 @@ X   https://github.com/processing/processing/pull/2659
 X   done with an approximation, if re-saving this will destroy data (docs)
 X fix typo in StringList.insert()
 X   https://github.com/processing/processing/pull/2672
+X StingList.insert() error (should be an easy fix)
+X   https://github.com/processing/processing/issues/2548
 
+earlier
+X default font fixes (merged for 2.2.1 or earlier)
+X   https://github.com/processing/processing/issues/2331
+X   https://github.com/processing/processing/pull/2338
 
-applet removal
+
+applet/component
 _ remove Applet as base class
 _ performance issues on OS X (might be threading due to Applet)
 _   https://github.com/processing/processing/issues/2423
 _ play with improvements to full screen here
 _ new full screen sometimes causes sketch to temporarily be in the wrong spot
+_ add option to have full screen span across screens
+_   display=all in cmd line
+_   sketchDisplay() -> 0 for all, or 1, 2, 3...
+_ clean up requestFocus() stuff
+_   make sure it works with retina/canvas/strategy as well
 
 
 processing.data
@@ -66,8 +78,6 @@ _   maybe once we make the PVector change
 high
 _ Closing opengl sketch from the PDE doesn't stop java process on windows
 _   https://github.com/processing/processing/issues/2335
-_ StingList.insert() error (should be an easy fix)
-_   https://github.com/processing/processing/issues/2548
 _ dataPath() not working when app is not run from app dir on Linux
 _   https://github.com/processing/processing/issues/2195
 _ "Buffers have not been created" error for sketches w/o draw()
@@ -85,23 +95,13 @@ _   internally, we probably have to call set() if it's a 1 pixel point
 _     but that's going to be a mess.. need to first check the CTM
 _ tint() not working in PDF (regression between 2.0.3 and 2.1)
 _   https://github.com/processing/processing/issues/2428
-_ default font fixes 
-_   https://github.com/processing/processing/issues/2331
-_   https://github.com/processing/processing/pull/2338
 _ Sort out blending differences with P2D/P3D
 _   might be that compatible images not setting alpha mode correctly
 _   image = gc.createCompatibleVolatileImage(source.width, source.height, Transparency.TRANSLUCENT);
 _   https://github.com/processing/processing/issues/1844
-_ add option to have full screen span across screens
-_   display=all in cmd line
-_   sketchDisplay() -> 0 for all, or 1, 2, 3...
-_ clean up requestFocus() stuff
-_   make sure it works with retina/canvas/strategy as well
 _ finish PFont.getShape() implementation
 _   needs to have a way to set width/height properly
 _   draw(s) doesn't work on the returned PShape
-_ TGA files writing strangely
-_   https://github.com/processing/processing/issues/2096
 
 
 hidpi
@@ -366,6 +366,9 @@ _   https://github.com/processing/processing/issues/1727
 
 CORE / PImage
 
+_ TGA files writing strangely
+_   https://github.com/processing/processing/issues/2096
+
 _ don't grab pixels of java2d images unless asked
 _   this is the difference between a lot of loadPixels() and not
 _   so important to have it in before beta if that's the change
diff --git a/java/libraries/net/src/processing/net/Server.java b/java/libraries/net/src/processing/net/Server.java
@@ -107,8 +107,9 @@ public Server(PApplet parent, int port, String host) {
       }
 
     } catch (IOException e) {
-      e.printStackTrace();
+      //e.printStackTrace();
       thread = null;
+      throw new RuntimeException(e);
       //errorMessage("<init>", e);
     }
   }
diff --git a/todo.txt b/todo.txt
@@ -31,6 +31,8 @@ X remove welcome message from the sound library
 X URL opening problem fixed by use of getCanonicalPath() on Windows
 X   https://github.com/processing/processing/issues/2656
 X add a new pref for the 3.0 sketchbook location
+X if Server constructor fails, throw an exception
+X   https://github.com/processing/processing/issues/2604
 _ when renaming a tab, include the previous name to be edited
 
 gsoc

Original file line number	Diff line number	Diff line change
`@@ -107,8 +107,9 @@ public Server(PApplet parent, int port, String host) {`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`} catch (IOException e) {`
`110`		`- e.printStackTrace();`
	`110`	`+ //e.printStackTrace();`
`111`	`111`	`thread = null;`
	`112`	`+ throw new RuntimeException(e);`
`112`	`113`	`//errorMessage("<init>", e);`
`113`	`114`	`}`
`114`	`115`	`}`