Skip to content

Commit dfb3458

Browse files
charles-salmontseaver
authored andcommitted
Ensure that ManagedZone:exists() does not misreport True result. (googleapis#6884)
Closes googleapis#5818.
1 parent aee5cec commit dfb3458

2 files changed

Lines changed: 1 addition & 5 deletions

File tree

dns/google/cloud/dns/zone.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -280,9 +280,7 @@ def exists(self, client=None):
280280
client = self._require_client(client)
281281

282282
try:
283-
client._connection.api_request(
284-
method="GET", path=self.path, query_params={"fields": "id"}
285-
)
283+
client._connection.api_request(method="GET", path=self.path)
286284
except NotFound:
287285
return False
288286
else:

dns/tests/unit/test_zone.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,6 @@ def test_exists_miss_w_bound_client(self):
330330
req = conn._requested[0]
331331
self.assertEqual(req["method"], "GET")
332332
self.assertEqual(req["path"], "/%s" % PATH)
333-
self.assertEqual(req["query_params"], {"fields": "id"})
334333

335334
def test_exists_hit_w_alternate_client(self):
336335
PATH = "projects/%s/managedZones/%s" % (self.PROJECT, self.ZONE_NAME)
@@ -347,7 +346,6 @@ def test_exists_hit_w_alternate_client(self):
347346
req = conn2._requested[0]
348347
self.assertEqual(req["method"], "GET")
349348
self.assertEqual(req["path"], "/%s" % PATH)
350-
self.assertEqual(req["query_params"], {"fields": "id"})
351349

352350
def test_reload_w_bound_client(self):
353351
PATH = "projects/%s/managedZones/%s" % (self.PROJECT, self.ZONE_NAME)

0 commit comments

Comments
 (0)