fix(deno): update types for deno ^1.4.0#100
Merged
bcoe merged 1 commit intoyargs:masterfrom Oct 1, 2020
Merged
Conversation
This was referenced Sep 30, 2020
Member
|
@luke-john mind making this PR against the main branch, |
In version 1.4 Deno adopted; - the tsconfig setting [importsNotUsedAsValues](https://www.typescriptlang.org/tsconfig#importsNotUsedAsValues) - denoland/deno#7413 This requires the use of; - type only imports for values which are only used as types (`importsNotUsedAsValues`)
bb2610a to
230f690
Compare
Contributor
Author
|
Updated to be target master (with the ci commit on the deno branch removed). cheers. |
bcoe
approved these changes
Oct 1, 2020
This was referenced Mar 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In version 1.4 Deno adopted;
This requires the use of;
importsNotUsedAsValues)I've added more details at yargs/yargs#1771.
related prs: