Skip to content

Removed Python 2.6 & 3.3#105

Merged
nitzmahone merged 11 commits intoyaml:masterfrom
engnadeau:patch-1
Feb 24, 2019
Merged

Removed Python 2.6 & 3.3#105
nitzmahone merged 11 commits intoyaml:masterfrom
engnadeau:patch-1

Conversation

@engnadeau
Copy link
Copy Markdown

@engnadeau engnadeau commented Dec 3, 2017 •
edited
Loading

@nnadeau
Removed Python 2.6
e6c100b 
DEPRECATION: Python 2.6 is no longer supported by the Python core team
hugovk
hugovk suggested changes Dec 4, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@hugovk hugovk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Don't forget to remove from here:

https://github.com/yaml/pyyaml/blob/master/.travis.yml#L9-L10
https://github.com/yaml/pyyaml/blob/master/setup.py#L30
https://github.com/yaml/pyyaml/blob/master/setup.cfg#L25

@engnadeau engnadeau mentioned this pull request Dec 4, 2017
Closed
@engnadeau
Copy link
Copy Markdown
Author

engnadeau commented Dec 4, 2017

@hugovk thanks for the reminder! Travis passes now

@engnadeau
Copy link
Copy Markdown
Author

engnadeau commented Dec 6, 2017

@alex @dstufft @hugovk is there anything else you'd like me to look into?

hugovk
hugovk approved these changes Dec 8, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@hugovk hugovk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

It would be good to add this to setup() in setup.py, so pip will install the correct distribution for the user's Python version:

python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*',

@engnadeau engnadeau changed the title Removed Python 2.6 Removed Python 2.6 & 3.3 Dec 8, 2017
@alex
Copy link
Copy Markdown
Contributor

alex commented Dec 8, 2017

I'd encourage the PyYAML maintainers to land this in a separate release from the current master. That is because master includes making PyYAML safe by default, and I don't want that to be denied to people who are (depressingly) insistent on using 2.6.

@engnadeau
Copy link
Copy Markdown
Author

engnadeau commented Dec 8, 2017 •
edited
Loading

@hugovk following your python_requires suggestion, I also noted that Py3.3 is EoL as well. The following commits also clean this up:

However, if you prefer, I can move this into its own PR

@alex, Python 2.6 builds are not passing on master...

@alex
Copy link
Copy Markdown
Contributor

alex commented Dec 9, 2017

They're failing because we install a version of wheel that's too new. I'm not saying this is good, I'd be very happy for Python 2.6 to die a firey death, but given the choice between YAML RCEs and Python2.6 fixes, I want everyone to get the RCE fixes.

@hugovk
Copy link
Copy Markdown
Contributor

hugovk commented Dec 9, 2017

As a compromise, how about making a release quite soon with the RCE fixes, then merging this right after release?

@alex
Copy link
Copy Markdown
Contributor

alex commented Dec 9, 2017

That sounds great to me. To the PyYAML maintainers: if there's anything I can do to help get a release out, please let me know!

@engnadeau
Copy link
Copy Markdown
Author

engnadeau commented Dec 10, 2017

@hugovk is there an open issue for YAML RCEs that we can link this PR to?

@hugovk
Copy link
Copy Markdown
Contributor

hugovk commented Dec 10, 2017

Let's ask @alex.

@alex
Copy link
Copy Markdown
Contributor

alex commented Dec 10, 2017

#74

@engnadeau
Copy link
Copy Markdown
Author

engnadeau commented Jan 5, 2018

Happy New Year @alex @hugovk @jdufresne !

What's the status of this PR?

@hugovk
Copy link
Copy Markdown
Contributor

hugovk commented Jan 5, 2018

Looks good to me, but I don't think any of us three can merge.

@engnadeau
Copy link
Copy Markdown
Author

engnadeau commented Jan 5, 2018

Ahh! @sigmavirus24 is the merger :)

@gdubicki
Copy link
Copy Markdown

gdubicki commented Apr 15, 2018

Python 2.6 tests are blocking #143 , which I care about. Can you please take a look at this MR, @sigmavirus24 ? Or otherwise perhaps share your permission with people who have more time for this project? Thanks in advance! :)

@perlpunk
Copy link
Copy Markdown
Member

perlpunk commented Apr 15, 2018

@gdubicki I believe tests for #143 were failing because of some travis + 2.6 issue. I just rebased my PR to master and force-pushed. 2.6 is passing now, waiting for 3.7-dev

@lorengordon lorengordon mentioned this pull request May 16, 2018
Closed
@nitzmahone nitzmahone merged commit 7ba0ad7 into yaml:master Feb 24, 2019
@hugovk hugovk mentioned this pull request Feb 24, 2019
Closed
@cclauss
Copy link
Copy Markdown
Contributor

cclauss commented Feb 24, 2019 •
edited
Loading

Perfect timing... 20 days until Python 3.4 end of life.

print((date(2019, 3, 16) - date.today()).days, 'days until Python 3.4 end of life.')

https://devguide.python.org/index?#status-of-python-branches

nitzmahone added a commit that referenced this pull request Feb 24, 2019
@nitzmahone
squash/merge pull request #105 from nnadeau/patch-1
760c02d 
Removed Python 2.6 & 3.3
ingydotnet pushed a commit that referenced this pull request Feb 25, 2019
@nitzmahone @ingydotnet
Squash/merge pull request #105 from nnadeau/patch-1
4ffd64a 
Removed Python 2.6 & 3.3
ingydotnet pushed a commit that referenced this pull request Feb 25, 2019
@nitzmahone @ingydotnet
Squash/merge pull request #105 from nnadeau/patch-1
9a24743 
Removed Python 2.6 & 3.3
@engnadeau engnadeau deleted the patch-1 branch February 25, 2019 17:49
ingydotnet pushed a commit that referenced this pull request Feb 26, 2019
@nitzmahone @ingydotnet
Squash/merge pull request #105 from nnadeau/patch-1
13cb653 
Removed Python 2.6 & 3.3
ingydotnet pushed a commit that referenced this pull request Feb 28, 2019
@nitzmahone @ingydotnet
Squash/merge pull request #105 from nnadeau/patch-1
5370614 
Removed Python 2.6 & 3.3
ingydotnet pushed a commit that referenced this pull request Mar 7, 2019
@nitzmahone @ingydotnet
Squash/merge pull request #105 from nnadeau/patch-1
944bf4f 
Removed Python 2.6 & 3.3
ingydotnet pushed a commit that referenced this pull request Mar 8, 2019
@nitzmahone @ingydotnet
Squash/merge pull request #105 from nnadeau/patch-1
b515dbf 
Removed Python 2.6 & 3.3
ingydotnet pushed a commit that referenced this pull request Mar 8, 2019
@nitzmahone @ingydotnet
Squash/merge pull request #105 from nnadeau/patch-1
91c9435 
Removed Python 2.6 & 3.3
@dandavison dandavison mentioned this pull request Oct 21, 2019
Merged
@RhythmicGaming RhythmicGaming mentioned this pull request Jan 15, 2020
Closed
@Ciemaar Ciemaar mentioned this pull request May 30, 2020
Merged
This was referenced Mar 9, 2021
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 17, 2021
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

+3 more reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@jdufresne jdufresne jdufresne approved these changes

@hugovk hugovk hugovk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.