Repository navigation
fix: Add missing variable declaration - #773
Merged
Merged
Conversation
styfle
force-pushed
the
fix-missing-tsconfig-var
branch
from
September 13, 2021 23:47
c32ae0e to
4deed52
Compare
TooTallNate
approved these changes
Sep 13, 2021
Timer
approved these changes
Mar 15, 2022
Timer
left a comment
Contributor
There was a problem hiding this comment.
LGTM if you wanna ship, otherwise, 📕! Maybe the side effect was important?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally removed a variable in PR #770
We should convert ncc source code to TS to catch these types of errors.
Update: this variable seems unused 🤷♂️
tsconfigMatchPathadded in Add support for tsconfigpaths. (fixes #150) #151tsconfigMatchPathremoved in New analysis updates #378