Conversation
styfle
commented
Sep 13, 2021
|
|
||
| if (process === null || process === void 0 ? void 0 : process.env.FOO) { | ||
| console.log('foo'); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@TooTallNate Here we can see the optional chaining operator is properly down-leveled 😌
mrmckeb
approved these changes
Sep 13, 2021
mrmckeb
left a comment
There was a problem hiding this comment.
It might be worth extracting walkParentDirs out, but not sure where...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug seen in PR vercel/vercel#6700 (see logs) where the
tsconfig.jsonis in a parent directory.The
tsconfig-pathspackage was returning an errorMissing baseUrl in compilerOptions.So instead, we'll manually walk up the filesystem to find the relevant
tsconfig.jsonlike we do in@vercel/build-utils.