Don't percent encode tilde characters in URL#1692
Merged
sethmlarson merged 1 commit intourllib3:masterfrom Sep 24, 2019
Merged
Conversation
pquentin
approved these changes
Sep 24, 2019
Member
pquentin
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for cleaning up this file.
Member
Author
|
Thanks for the review @pquentin! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Erroneously left the tilde
~character out of theUNRESERVED_CHARSsection causing them to be percent-encoded. This caused issues with users that had tildes in paths.Closes #1683.
Closes #1684.