Change ambiguous description of backoff_factor#1436
Merged
sethmlarson merged 1 commit intourllib3:masterfrom Sep 9, 2018
Mattwmaster58:patch-1
Merged
Change ambiguous description of backoff_factor#1436sethmlarson merged 1 commit intourllib3:masterfrom Mattwmaster58:patch-1
sethmlarson merged 1 commit intourllib3:masterfrom
Mattwmaster58:patch-1
Conversation
Change from `^` to `**`. Programmers not familiar with python might assume the ^ is the exponent operator, when in fact it is the bitwise XOR operator. This change will remove the ambiguity.
Codecov Report
@@ Coverage Diff @@
## master #1436 +/- ##
========================================
Coverage ? 100%
========================================
Files ? 21
Lines ? 1790
Branches ? 0
========================================
Hits ? 1790
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
sethmlarson
approved these changes
Sep 9, 2018
Member
sethmlarson
left a comment
There was a problem hiding this comment.
I agree that this change is definitely better in a Python context. Thanks for this! 🎉
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
Dobatymo
pushed a commit
to Dobatymo/urllib3
that referenced
this pull request
Mar 16, 2022
Change from `^` to `**`. Programmers not familiar with python might assume the ^ is the exponent operator, when in fact it is the bitwise XOR operator. This change will remove the ambiguity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change from
^to**. Programmers not familiar with python might assume the ^ is the exponent operator, when in fact it is the bitwise XOR operator. This change will remove the ambiguity.