Skip to content

Don't add empty content holder when there is no content available#33982

Merged
XhmikosR merged 5 commits intomainfrom
rs-popover-title
May 18, 2021
Merged

Don't add empty content holder when there is no content available#33982
XhmikosR merged 5 commits intomainfrom
rs-popover-title

Conversation

@rohit2sharma95
Copy link
Copy Markdown
Contributor

Fixes #29127
Alternative to #29570

A popover should not have an empty header or body when the content is not available on the main element or in the configuration.

@rohit2sharma95 rohit2sharma95 marked this pull request as ready for review May 14, 2021 09:07
@rohit2sharma95 rohit2sharma95 requested a review from a team as a code owner May 14, 2021 09:07
Comment thread js/src/popover.js Outdated
Comment thread js/src/popover.js Outdated
Comment thread js/src/popover.js Outdated
Comment thread js/src/popover.js
@XhmikosR XhmikosR merged commit 153cf3a into main May 18, 2021
@XhmikosR XhmikosR deleted the rs-popover-title branch May 18, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

empty h3 in popover when title is not defined

3 participants