Skip to content

Reduce color-scheme complexity#33607

Merged
mdo merged 1 commit intomainfrom
main-fod-simpler-color-scheme
Apr 14, 2021
Merged

Reduce color-scheme complexity#33607
mdo merged 1 commit intomainfrom
main-fod-simpler-color-scheme

Conversation

@ffoodd
Copy link
Copy Markdown
Contributor

@ffoodd ffoodd commented Apr 10, 2021

Since light and dark are used in media-query the same way any named argument is, there's no point using conditions to output them. Am I missing something?

Sorry I missed that somehow, didn't see the PR sooner.

@ffoodd ffoodd requested a review from a team as a code owner April 10, 2021 19:18
Copy link
Copy Markdown
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants