Adding an asyncio.gather() replacement for tqdm#1136
Merged
casperdcl merged 5 commits intotqdm:masterfrom Mar 5, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1136 +/- ##
==========================================
+ Coverage 84.75% 84.81% +0.06%
==========================================
Files 24 24
Lines 1620 1627 +7
Branches 267 270 +3
==========================================
+ Hits 1373 1380 +7
Misses 209 209
Partials 38 38 |
Author
|
I'm not too sure how to make this work for older python versions, or whether it's possible, sorry! If someone could point me in the right direction, I might be able to make whatever changes are required |
- reorder imports - fix line length
Member
|
thanks for this. Made a few changes:
|
Author
|
Oh that's amazing! I didn't expect that you would fix it all up and neaten it yourself, thank you! |
Merged
This was referenced Mar 8, 2021
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tqdm's as_completed() is helpful, but does mean results are not in the same order as inputs, which can be frustrating.
I've tried writing a wrapper which emulates the behaviour of asyncio.gather, though I'm not sure whether this conforms to the ideas of the project. (I'm not sure the
typingimport will be well appreciated, at the very least)