Refactor WorkflowWorker to put eager activity dispatch in the right place#1453
Merged
Spikhalskiy merged 1 commit intotemporalio:masterfrom Sep 25, 2022
Merged
Conversation
51d27f9 to
152380b
Compare
152380b to
64cf1d7
Compare
bergundy
approved these changes
Sep 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Eager activity dispatch is buried deep down inside
sendReplymethod where it does not belong.This creates a surprising behavior of
sendReply, code that is harder to follow and modify in the future.