Fix leaking Eager Activity Reservation#1452
Merged
Spikhalskiy merged 1 commit intotemporalio:masterfrom Sep 24, 2022
Merged
Conversation
Sushisource
approved these changes
Sep 24, 2022
Member
Sushisource
left a comment
There was a problem hiding this comment.
I warned you! 😆
Tricky to get these right.
2a1f1c3 to
216f6e8
Compare
mjameswh
approved these changes
Sep 24, 2022
402f962 to
4c960f6
Compare
4c960f6 to
fa9b3be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently added eager activity dispatch leads to a leaky semaphore. If an activity is actually eagerly dispatched, the semaphore gets incremented twice.
Eager activity dispatch functionality needs better tests for potential semaphore leaks.