Fix MTLS configuration in spring boot autoconfiguration#1441
Merged
Spikhalskiy merged 4 commits intotemporalio:masterfrom Sep 16, 2022
Merged
Fix MTLS configuration in spring boot autoconfiguration#1441Spikhalskiy merged 4 commits intotemporalio:masterfrom
Spikhalskiy merged 4 commits intotemporalio:masterfrom
Conversation
yassineb
commented
Sep 16, 2022
| @@ -0,0 +1,28 @@ | |||
| -----BEGIN CERTIFICATE----- | |||
Contributor
Author
There was a problem hiding this comment.
@Spikhalskiy I copied the certs from temporal-serviceclient. I noticed the certificate is expiring at the end of the year, we should probably update them to avoid unit tests failing in a few months.
Contributor
|
Thank you for the contribution! This looks great. |
Spikhalskiy
approved these changes
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
MTLS configuration fails to load certificates due to input stream already closed. The read from the stream happens within the SSLContextBuilder::build method (specifically when calling sslContextBuilder.keyManager) which is outside the try-with-resource.