Optimize unneeded string concatenation#1433
Merged
Spikhalskiy merged 1 commit intotemporalio:masterfrom Sep 15, 2022
Merged
Conversation
cretz
approved these changes
Sep 15, 2022
Contributor
cretz
left a comment
There was a problem hiding this comment.
Definitely some micro-optimization, though I know it's on a hot path. Wonder if it'd be worth any included micro-benchmarking in the test suite.
Contributor
Author
|
@cretz It is, but it's a silly mistake to make an eager concatenation here while this string ideally should never be used at all. I think we are in pre-microbenchmarking era yet, where I'm just fixing mostly obvious silly things. Later some elements may be worth isolating and micro benchmarking. Like the cooperative multithreading runner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.