History iteration should never ever fail a workflow execution#1404
Merged
Spikhalskiy merged 1 commit intotemporalio:masterfrom Sep 2, 2022
Merged
History iteration should never ever fail a workflow execution#1404Spikhalskiy merged 1 commit intotemporalio:masterfrom
Spikhalskiy merged 1 commit intotemporalio:masterfrom
Conversation
Even if `Throwable` is set on the failWorkflowExceptionTypes
382fcf2 to
3966eae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
After this change, workflow history iteration exceptions never fail workflow executions.
Even if
Throwableis set on the failWorkflowExceptionTypes.Why
It's likely never an intention or expectation of the user that a workflow will start to fail on such internal machinery as workflow iterations and because of a temporary unavailable or a slow server. Also, workflow iteration exceptions are not like the state machine's
NonDeterministicException, they are always retryable and recoverable. So it seems like failing a workflow execution on history iteration failures because of connectivity issues is always a bad idea. Instead, a Workflow Task should be failed.