Don't use BackoffThrottler in multithread contexts#1467
Merged
mjameswh merged 4 commits intotemporalio:masterfrom Oct 13, 2022
Merged
Don't use BackoffThrottler in multithread contexts#1467mjameswh merged 4 commits intotemporalio:masterfrom
mjameswh merged 4 commits intotemporalio:masterfrom
Conversation
Spikhalskiy
reviewed
Sep 30, 2022
Spikhalskiy
approved these changes
Sep 30, 2022
Spikhalskiy
approved these changes
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
GrpcAsyncRetryerto carry its state in fields instead of passing them as argumentsGrpcAsyncRetryer, instead of having a global oneGrpc*RetryerTestto more strongly validate either the test is expected to retry, and how long these retries should take (checking for either max or min possible time)Why?
BackoffThrottlerwas not designed to provide an external thread safe semantic; consequently, a race condition between several threads could result in skipping throttling or in throttling more than expected.