Fix incorrect handling of -RC suffix in version#1466
Merged
mjameswh merged 3 commits intotemporalio:masterfrom Sep 30, 2022
Merged
Fix incorrect handling of -RC suffix in version#1466mjameswh merged 3 commits intotemporalio:masterfrom
mjameswh merged 3 commits intotemporalio:masterfrom
Conversation
Contributor
will it be hard to change the behavior to |
Contributor
Author
Very easy, but I think it is wrong. Conceptually, 0.20.0-RC1 specifically means that the previous version was 0.19.0 and that you are now in the process of moving to 0.20.0, not 0.21.0... But I won't fight on this. Your call. |
Contributor
|
@mjameswh you are right, corrected the proposal. |
Spikhalskiy
reviewed
Sep 30, 2022
Spikhalskiy
approved these changes
Sep 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Rewrite the way the gradle build script determine the version number.
Why?
Previous logic would produce incorrect version number if git tag was of the form
1.17.0-RC1-2, which would cause further build to fail.See: https://buildkite.com/temporal/java-sdk-public/builds/1877#01838a2b-de0c-42e7-b44a-fe541f1e4570/791-853