Add support for strict JSON comparison in WebTestClient#27993
Closed
elgleidson wants to merge 4 commits intospring-projects:mainfrom
elgleidson:main
Closed
Add support for strict JSON comparison in WebTestClient#27993elgleidson wants to merge 4 commits intospring-projects:mainfrom elgleidson:main
elgleidson wants to merge 4 commits intospring-projects:mainfrom
elgleidson:main
Conversation
|
@elgleidson Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@elgleidson Thank you for signing the Contributor License Agreement! |
Member
|
It looks like the code examples for |
Contributor
Author
Done. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for
expectedBody().json(<expected strict json>, true);Part of the code base already has support - via
JsonExpectationsHelper- butWebTestClienthas no method to use the strict version. The existing method useslenient, which is not always desired.Example:
Let's say
/persons/1/returns the following response:{ "name":"John", "surname":"Smith" }The following test works fine:
I'm just adding a new method so that we can use strict comparison when appropriate.
Example:
This test fails because the response has more fields than expected and we're using strict mode:
But the following test passes because we're expecting all fields: