Clarify that ClientRequest.from(..) also copies body#27220
Closed
AlexejTimonin wants to merge 5 commits intospring-projects:mainfrom
Closed
Clarify that ClientRequest.from(..) also copies body#27220AlexejTimonin wants to merge 5 commits intospring-projects:mainfrom
AlexejTimonin wants to merge 5 commits intospring-projects:mainfrom
Conversation
|
@AlexejTimonin Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@AlexejTimonin Thank you for signing the Contributor License Agreement! |
qiangmao
reviewed
Jul 30, 2021
sbrannen
requested changes
Jul 30, 2021
Member
sbrannen
left a comment
There was a problem hiding this comment.
I've requested one small change to document that "attributes" are copied as well.
Please also update the copyright date in ClientRequest and DefaultClientRequestBuilderTests.
Co-authored-by: Sam Brannen <sbrannen@vmware.com>
Contributor
Author
|
@sbrannen I could not see any tests for attributes in |
sbrannen
approved these changes
Jul 31, 2021
rstoyanchev
pushed a commit
that referenced
this pull request
Aug 4, 2021
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this pull request
Mar 26, 2022
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this pull request
Mar 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClientRequest.from(..)will also copy body from the given request.