Remove unnecessary test_files from the gemspec#1712
Merged
jkowens merged 1 commit intosinatra:masterfrom Aug 17, 2021
Merged
Conversation
epergo
approved these changes
Jul 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
test_filesfrom the gemspec because it is unnecessary.Sinatra sets an empty array to
test_filessince 9871970. The commit omitstest/directory from published package.So currently the
test_filesoption does nothing.We have two choices, removing the
test_files, or adding files undertest/totest_files.I think the first approach, removing
test_files, is better. Becausetset_filesis no longer recommended. ref: rubygems/guides#90 rubygems/bundler#3207And I guess Sinatra users don't need
test_filesbecause they had no trouble with emptytest_files.