Skip to content

Add #select, #reject and #compact methods to Sinatra::IndifferentHash#1711

Merged
jkowens merged 1 commit intosinatra:masterfrom
olivierbellone:ob-more-indifferent-methods
Aug 17, 2021
Merged

Add #select, #reject and #compact methods to Sinatra::IndifferentHash#1711
jkowens merged 1 commit intosinatra:masterfrom
olivierbellone:ob-more-indifferent-methods

Conversation

@ob-stripe
Copy link
Copy Markdown
Contributor

@ob-stripe ob-stripe commented Jul 22, 2021

This PR adds #select, #reject and #compact methods to Sinatra::IndifferentHash.

This allows the following code to work:

foo_strings = params[:foo].select {|_, v| v.is_a?(String)}

if foo_strings[:bar]
  ...

Without this PR, the code above would fail because select returns a regular Hash with string keys.

@jkowens
Copy link
Copy Markdown
Member

jkowens commented Aug 17, 2021

Looks good, thanks!

@jkowens jkowens merged commit 7092f0e into sinatra:master Aug 17, 2021
@ob-stripe
Copy link
Copy Markdown
Contributor Author

ob-stripe commented Aug 17, 2021

Thank you! Do you know if a release is planned sometimes soon?

@jkowens
Copy link
Copy Markdown
Member

jkowens commented Aug 17, 2021

Honestly, I don't know. I don't have the ability to cut a release. Maybe @namusyaka or @zzak could weigh in on that?

@zzak
Copy link
Copy Markdown
Member

zzak commented Aug 23, 2021

Personally I have no plans to release soon, please ping me if there's something urgent we should do. 🙇

This was referenced Nov 22, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ob-stripe @jkowens @zzak