Skip to content

Revert "Use prepend instead of include for helpers. Fixes #1213"#1662

Merged
namusyaka merged 5 commits intomasterfrom
revert-1214-prepend-helpers
Nov 11, 2020
Merged

Revert "Use prepend instead of include for helpers. Fixes #1213"#1662
namusyaka merged 5 commits intomasterfrom
revert-1214-prepend-helpers

Conversation

@namusyaka
Copy link
Copy Markdown
Member

Reverts #1214
cc @jkowens

@namusyaka namusyaka changed the title Revert "Use prepend instead of include for helpers. Fixes #1213" WIP: Revert "Use prepend instead of include for helpers. Fixes #1213" Nov 4, 2020
@namusyaka namusyaka requested a review from jkowens November 4, 2020 17:39
@namusyaka namusyaka changed the title WIP: Revert "Use prepend instead of include for helpers. Fixes #1213" Revert "Use prepend instead of include for helpers. Fixes #1213" Nov 4, 2020
Copy link
Copy Markdown
Member

@jkowens jkowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@basex
Copy link
Copy Markdown

basex commented Nov 10, 2020

Padrino doesn't load on the last versions when people use mailers. This fixes padrino/padrino-framework#2232 Can this be merged?

@namusyaka namusyaka merged commit a9649b4 into master Nov 11, 2020
@namusyaka namusyaka deleted the revert-1214-prepend-helpers branch November 11, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants