Skip to content

Pass noproxy options from outside proxy to selenide proxy - #1390

Merged
BorisOsipov merged 1 commit into
masterfrom
fix_no_proxy_options
Jan 29, 2021
Merged

BorisOsipov merged 1 commit into
masterfrom
fix_no_proxy_options

Conversation

@BorisOsipov

Copy link
Copy Markdown
Collaborator

The problem

Proxy proxy = new Proxy();
proxy.setHttpProxy("127.0.0.1:3128"); 
proxy.setNoProxy("localhost");
WebDriverRunner.setProxy(proxy);      
Configuration.proxyEnabled = true;
open("http://localhost")

it can not open localhost because noproxy settings gets lost.

Checklist

  • Checkstyle and unit tests are passed locally with my changes by running gradlew check chrome_headless firefox_headless command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@BorisOsipov
BorisOsipov requested a review from a team January 29, 2021 11:32

@asolntsev asolntsev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BorisOsipov do i correctly understand that this change is not "Pass noproxy options TO outside proxy", but "Pass noproxy options FROM outside proxy TO selenide proxy"?

otherwise looks good.

@BorisOsipov

Copy link
Copy Markdown
Collaborator Author

@asolntsev yep.

@BorisOsipov
BorisOsipov merged commit b931061 into master Jan 29, 2021
@BorisOsipov
BorisOsipov deleted the fix_no_proxy_options branch January 29, 2021 12:40
@asolntsev asolntsev added this to the 5.18.1 milestone Feb 11, 2021
@asolntsev asolntsev changed the title Pass noproxy options to outside proxy Pass noproxy options from outside proxy to selenide proxy Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants