Skip to content

Make unused-import warnings easier to silence (support filtering by origin=)#9939

Merged
lrytz merged 2 commits intoscala:2.13.xfrom
som-snytt:issue/12326
Mar 3, 2022
Merged

Make unused-import warnings easier to silence (support filtering by origin=)#9939
lrytz merged 2 commits intoscala:2.13.xfrom
som-snytt:issue/12326

Conversation

@som-snytt
Copy link
Copy Markdown
Contributor

@som-snytt som-snytt commented Feb 14, 2022

This allows nowarn by regex matching the fully-qualified selector string. For import a.{b, _}, match a.b or a._.

Fixes scala/bug#12326

This allows nowarn by regex matching the fully-qualified
selector string. For `import a.{b, _}`, match `a.b` or `a._`.
@scala-jenkins scala-jenkins added this to the 2.13.9 milestone Feb 14, 2022
@som-snytt som-snytt requested a review from lrytz February 14, 2022 09:20
@som-snytt
Copy link
Copy Markdown
Contributor Author

We need a label for "review-friendly!"

Copy link
Copy Markdown
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but ideally @lrytz would take a look as well, let's see if we attract his attention

@som-snytt
Copy link
Copy Markdown
Contributor Author

This work just stands on his shoulders.

Copy link
Copy Markdown
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice :)

@lrytz lrytz merged commit 0bcc7dd into scala:2.13.x Mar 3, 2022
@som-snytt som-snytt deleted the issue/12326 branch March 11, 2022 18:24
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Mar 11, 2022
@SethTisue SethTisue changed the title Import warnings have an origin Make unused-import warnings easier to silence Mar 11, 2022
@SethTisue SethTisue changed the title Make unused-import warnings easier to silence Make unused-import warnings easier to silence (by filtering with origin=) Mar 11, 2022
@SethTisue SethTisue changed the title Make unused-import warnings easier to silence (by filtering with origin=) Make unused-import warnings easier to silence (support filtering by origin=) Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes worth highlighting in next release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unused imports difficult to silence

4 participants