Merged
Conversation
Member
jdleesmiller
left a comment
There was a problem hiding this comment.
Thanks for taking this on!
I am definitely OK with doing this gradually, and as you say this looks like a good start.
I have been through, and all looks good. Just a few comments. (And as usual I learned about some new ruby things, such as unpack1!)
Also rename .rubocop_rubyzip.yml to be consistent with Rubocop default setup.
This fixes Style/InfiniteLoop as a side-effect.
Allow this in entry_test.rb so we can test <=>.
In the tests we can say "anything goes", but in the main body of the code we should at least comment if we're not handling an exception fully.
Use the `refute_nil` method for most of these.
Currently 2.4 is the earliest supported ruby version.
3e34d3b to
87a63e0
Compare
Member
Author
|
@jdleesmiller I've made the changes and rebased on top of current master. Just the one comment about |
jdleesmiller
added a commit
that referenced
this pull request
Feb 16, 2020
This was referenced Mar 11, 2021
This was referenced Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to the current version of Rubocop and tackle the majority of the issues.
I've made some calls here and there - mainly with turning off some cops in the tests. Sometimes tests just need to be long/complex/etc and splitting them up doesn't make much sense.
There are some cops I haven't had time to really tackle yet (Style/FrozenStringLiteralComment, Style/MutableConstant for example) because fixing these will have some side effects that need thought, or serious re-working of the code.
I originally did this a few months ago, and it's taken a fair amount of effort to rebase/cherry-pick/rework it, so even though there are still some bits to finish up I think it's worth merging; it gets us most of the way and can be built upon from here.