Support the commit --no-gpg-sign flag#589
Merged
jcouball merged 5 commits intoruby-git:masterfrom Aug 18, 2022
Merged
Conversation
Signed-off-by: Bradley Buda <bradleybuda@gmail.com>
Member
|
@bradleybuda I like this PR, but I request the following change: Instead of passing
The design of the API mimics what you would pass on the command line. Like it or not, that is the design we have today. |
Member
|
I have fixed the Ruby 2.7 windows-latest build in #591 |
Contributor
Author
|
Thanks for the comment @jcouball, updated the patch. I hadn't noticed that there were some other |
Signed-off-by: Bradley Buda <bradleybuda@gmail.com>
0d2a03a to
b79028f
Compare
Signed-off-by: Bradley Buda <bradleybuda@gmail.com>
jcouball
approved these changes
Aug 18, 2022
Member
jcouball
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the thorough tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to send the
--no-gpg-signoption to git. This is the default behavior in a "vanilla" git install, but if gpg signing is configured elsewhere (i.e. in~/.gitconfig) then you can use this option to override and disable it for a particular commit.Triggered by
gpg_sign: false- see test and README updates.