Fix worktree test when git dir includes symlinks#522
Merged
jcouball merged 1 commit intoruby-git:masterfrom Jul 6, 2021
jcouball:fix_test
Merged
Fix worktree test when git dir includes symlinks#522jcouball merged 1 commit intoruby-git:masterfrom jcouball:fix_test
jcouball merged 1 commit intoruby-git:masterfrom
jcouball:fix_test
Conversation
Signed-off-by: James Couball <jcouball@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Couball jcouball@yahoo.com
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
This is a fix for running unit tests on Mac where /tmp is actually a symlink to /private/tmp.
Git#dirreturns the directory you give it andWorktree#dirreturns the expanded path since that is whatgit workspace listreturns.Some additional thought will have to be put into considering if
Git#dirshould also return the expanded path.