Adds file option to config_set to allow adding to specific git-config files#458
Adds file option to config_set to allow adding to specific git-config files#458jcouball merged 4 commits intoruby-git:masterfrom
Conversation
… files Signed-off-by: Valentino Stoll <v@codenamev.com>
|
A friendly reminder that this issue had no activity for 60 days. |
|
@jcouball from the contributing docs it says to request a review from a maintainer. I'm not entirely sure on the process for doing that (outside of pinging you directly like this). If there is a preference of process I'd be happy to document it 😄 I'm unable to request a review via the typical GitHub UI. |
|
A friendly reminder that this issue had no activity for 60 days. |
jcouball
left a comment
There was a problem hiding this comment.
Apologies for taking so long to get to this. This addition looks great!
The only thing it is missing is an entry in the README. I'll add this if I don't see a PR in the next day or two.
I'll plan on cutting a new minor-version release within the next week to get this in the gem.
PR checklist
Description
There are many git configurations that are preferred to keep in a separate file to avoid committing sensitive information (in a global dotfile as an example). This updates the
.configmethod to accept afileoption that allows you to specify the file to save the configuration to (this is equivalent togit config --file some/custom/config name value).