Change not to set the size attribute to svg element#377
Merged
kamijin-fanta merged 1 commit intoreact-icons:masterfrom Nov 26, 2020
Merged
Change not to set the size attribute to svg element#377kamijin-fanta merged 1 commit intoreact-icons:masterfrom
kamijin-fanta merged 1 commit intoreact-icons:masterfrom
Conversation
kamijin-fanta
approved these changes
Nov 26, 2020
Member
|
tanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When use the
sizeproperty to change icon size, thesizeattribute is set to svg element like this.But the
sizeattribute is not allowed on svg element, so this PR changes not to set thesizeattribute to svg element.