Allow unfunctioing pydoc to fail#2049
Merged
gaborbernat merged 2 commits intopypa:mainfrom Jan 12, 2021
d125q:allow-unfunctioning-pydoc-to-fail
Merged
Allow unfunctioing pydoc to fail#2049gaborbernat merged 2 commits intopypa:mainfrom d125q:allow-unfunctioning-pydoc-to-fail
gaborbernat merged 2 commits intopypa:mainfrom
d125q:allow-unfunctioning-pydoc-to-fail
Conversation
Otherwise, one cannot activate a virtualenv under Zsh with set -e.
Codecov Report
@@ Coverage Diff @@
## main #2049 +/- ##
==========================================
- Coverage 94.04% 94.01% -0.03%
==========================================
Files 87 87
Lines 4331 4331
==========================================
- Hits 4073 4072 -1
- Misses 258 259 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gaborbernat
requested changes
Jan 12, 2021
Contributor
gaborbernat
left a comment
There was a problem hiding this comment.
Please add a changelog entry, thanks!
Contributor
Author
Added; thanks likewise! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, one cannot activate a virtualenv under Zsh with set -e.
As an example,
fails with exit code 1 because there is nothing to unset. (The relevant version are: zsh 5.8.0.2-dev (x86_64-pc-linux-gnu), Python 3.9.1, and virtualenv 20.3.0.)