Add --readonly-app-data option#2009
Merged
gaborbernat merged 1 commit intopypa:mainfrom Nov 21, 2020
asottile:readonly_app_data
Merged
Add --readonly-app-data option#2009gaborbernat merged 1 commit intopypa:mainfrom asottile:readonly_app_data
gaborbernat merged 1 commit intopypa:mainfrom
asottile:readonly_app_data
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2009 +/- ##
==========================================
+ Coverage 94.32% 94.36% +0.04%
==========================================
Files 86 87 +1
Lines 4280 4316 +36
==========================================
+ Hits 4037 4073 +36
Misses 243 243
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
I believe this is ready for review now 🎉 |
gaborbernat
requested changes
Nov 20, 2020
Contributor
gaborbernat
left a comment
There was a problem hiding this comment.
The test suite on Windows 2.7 seems to be failing. The delta coverage is 90%, can you please bring it up to 100%? Otherwise conceptually the PR looks good.
Contributor
Author
gaborbernat
reviewed
Nov 20, 2020
gaborbernat
reviewed
Nov 20, 2020
gaborbernat
reviewed
Nov 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2000
Thanks for contributing, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix_lint)docs/changelogfolder