Improve handling of missing config file#770
Merged
bhrutledge merged 5 commits intopypa:mainfrom Jul 3, 2021
Merged
Conversation
Contributor
Author
|
@pypa/twine-maintainers Friendly nudge for some feedback. 😅 |
sigmavirus24
approved these changes
Jul 2, 2021
jaraco
approved these changes
Jul 2, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #564
There's a lot here, but my hope is that it makes things clearer for users and contributors. I tried to organize the commits so that they could be reviewed individually; for example, the change that addresses @angerson's suggestion in #564 (comment) is fd51ed1.
New output:
The second example is new behavior. Currently, Twine silently ignores the missing file, and returns a default configuration for PyPI and TestPyPI. However, if a user takes the time to specify
--config-fileon the command line, and the file doesn't exist, that feels like it should be an error. These changes include a special case to continue to provide a default configuration if--config-fileisn't used.