Skip to content

Prefer importlib_metadata for entrypoint parsing.#728

Merged
bhrutledge merged 4 commits intomasterfrom
feature/importlib-metadata-for-entrypoints
Feb 21, 2021
Merged

Prefer importlib_metadata for entrypoint parsing.#728
bhrutledge merged 4 commits intomasterfrom
feature/importlib-metadata-for-entrypoints

Conversation

@jaraco
Copy link
Copy Markdown
Member

@jaraco jaraco commented Jan 20, 2021

Fix for #338 (comment)

Comment thread twine/cli.py Outdated
@bhrutledge
Copy link
Copy Markdown
Contributor

@jaraco It might be out of scope for this PR, but what do you think about completely removing pkg_resources as a dependency? Looks like the only other place it's used https://github.com/pypa/twine/blob/master/twine/package.py.

@jaraco
Copy link
Copy Markdown
Member Author

jaraco commented Jan 21, 2021

@jaraco It might be out of scope for this PR, but what do you think about completely removing pkg_resources as a dependency? Looks like the only other place it's used https://github.com/pypa/twine/blob/master/twine/package.py.

I peeked at that briefly and decided it was out of scope, but I'm in favor of getting that out also, but separately.

@bhrutledge
Copy link
Copy Markdown
Contributor

@jaraco I fixed the typing errors for 3.6 and 3.7 in 0d5aab4.

Is there anything else to do with this before merge? Maybe a changelog entry? 😉

@jaraco
Copy link
Copy Markdown
Member Author

jaraco commented Jan 29, 2021

@jaraco I fixed the typing errors for 3.6 and 3.7 in 0d5aab4.

Thanks

Is there anything else to do with this before merge? Maybe a changelog entry? 😉

Done

@jaraco
Copy link
Copy Markdown
Member Author

jaraco commented Feb 21, 2021

Consider merging please.

@bhrutledge bhrutledge merged commit 7e95990 into master Feb 21, 2021
@bhrutledge bhrutledge deleted the feature/importlib-metadata-for-entrypoints branch February 21, 2021 20:19
@bhrutledge
Copy link
Copy Markdown
Contributor

Happy to (though I guess assumed you would).

This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants