Merged
Conversation
- Check that out STDIN black support stays working - Add asyncio.subprocess STDIN pip via communicate - We just check we format python code from primer's `lib.py` Fixes #2310
cb22aca to
c44951b
Compare
Collaborator
Author
|
I think we need to revise the |
Collaborator
|
Why do we need to test this with primer specifically? There are already various unit tests for stdin in test_black.py. |
Collaborator
Author
|
This ensures we don’t break the ‘-‘ cli and the whole pipeline from stdin to return value using this read from STDIN option. I've seen Unit tests miss things before and this was simple to add and fast to execute so I see no downside to this. It also keeps our integrations tests testing as much as we can. Next I’d like to get some different CLI usages too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib.pyFixes #2310