Detect missing arg for prepare-commit-msg and commit-msg#1341
Merged
asottile merged 1 commit intopre-commit:masterfrom Feb 23, 2020
Merged
Detect missing arg for prepare-commit-msg and commit-msg#1341asottile merged 1 commit intopre-commit:masterfrom
asottile merged 1 commit intopre-commit:masterfrom
Conversation
asottile
reviewed
Feb 22, 2020
9f217f4 to
fc8ced7
Compare
If using the prepare-commit-msg and commit-msg stages specifically (such
as with the try-repo command), the `--commit-msg-filename` arg must be
provided.
[fixes pre-commit#1336]
chore: improve error message for hook stage check
fc8ced7 to
5258dce
Compare
Member
|
I went ahead and:
|
Contributor
Author
|
Nice... admittedly I was trying to familiarize myself with all the functions you're using in your unit tests but I just haven't had the time this weekend. |
Member
|
no problem! patch looked good and I wanted to build on it in some other PRs which would have conflicted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If using the prepare-commit-msg and commit-msg stages specifically (such as with the try-repo command), the
--commit-msg-filenamearg must be provided.Resolves #1336