Conversation
|
neat! looks like a good start -- with some tests should probably be good enough as a v1 implementation! |
|
Any hints for getting up to speed with writing the tests as easily as possible? :) |
|
Sure! For this I think there's ~two main tests you'll want to add:
depending on what's out-of-the-box on azurepipelines we'll probably also need to install perl (?) |
|
if you get stuck I can probably help -- but you'll need to teach me a bit about perl package management :) |
|
Thanks, I'll have a look. Additional deps already worked when I tested them -- there are multiple ways one can specify them for I have no clue about perl in azure, and I'm more familiar with travis anyway, but I don't think it will be a problem at all, just something one needs to add. One future improvement would be to support repos with |
|
Ok, got those implemented. Linux ok locally and in Azure, but tox_windows py37 fails writing a state file there or something, or maybe it's a result/side effect of something else. I guess it's a fair assumption that perl isn't installed in Windows there, but dunno if it could cause something like that. I'm afraid I'll need someone to look into this. |
|
I believe I've fixed windows 🤞 -- played around this with a VM -- it also looks like azure pipelines preinstalls "strawberry perl" so perl should already be available |
|
🎉 thanks for the patch! |
|
this has been released as part of v2.1.0 -- thanks again! |
Here's a first cut for supporting Perl hooks. Appears to work for me with this .pre-commit-hooks.yaml locally added to a https://github.com/perltidy/perltidy clone + the usual config to use it elsewhere:
No tests yet, haven't taken a look what it would take to add some. Throwing this here for comments already anyway.