exclude GIT_SSL_NO_VERIFY env variable from getting stripped#1293
Merged
asottile merged 1 commit intopre-commit:masterfrom Jan 21, 2020
Merged
exclude GIT_SSL_NO_VERIFY env variable from getting stripped#1293asottile merged 1 commit intopre-commit:masterfrom
asottile merged 1 commit intopre-commit:masterfrom
Conversation
Member
|
that's actually kinda terrifying -- doesn't this variable expose you to all sorts of malicious MITM? I'm looking into why windows CI is failing -- I suspect a bad azure pipelines release :( |
Member
|
I've opened https://github.com/microsoft/azure-pipelines-image-generation/issues/1468 for the |
Contributor
Author
|
Yeah, a bit yes. The proxy itself is pretty restricting and only allows connections to a handful of public domains such as github.com - and it does verify certs. So it's only a matter of trusting the path to the proxy inside the company network ... |
asottile
approved these changes
Jan 21, 2020
Member
asottile
left a comment
There was a problem hiding this comment.
change seems fine (though scary!), I'll merge after fixing CI
Member
|
this has been released as part of v2.0.0 -- thanks again for the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can this change please get merged? We sit behind a proxy that messes with certificates...